Fix case where pip requiremet version starts with != #35645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github provider has package starting with `!=` and the documentation generation had a bug (for a long time) to split the package versions wrongly in this case.
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:github
labels
potiuk
commented
Nov 15, 2023
| @@ -39,5 +39,5 @@ | |||
| "2.5.0" | |||
| ): | |||
| raise RuntimeError( | |||
| f"The package `apache-airflow-providers-github:{__version__}` requires Apache Airflow 2.5.0+" | |||
There was a problem hiding this comment.
Latest template applied here as well (cc: @eladkal - this the case whe you can use --reapply-templates-only
Changes in docs were done with (after implementing the fix)
breeze release-management prepare-provider-documentation github --reapply-templates-only
uranusjr
approved these changes
Nov 15, 2023
Sure. PRS are more welcome. One of the reasons why I now work on moving all the code for packaging to |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github provider has package starting with
!=and the documentation generation had a bug (for a long time) to split the package versions wrongly in this case.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.