Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move external logs links to top of react logs page #35668

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Move external logs links to top of react logs page #35668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 16 additions & 20 deletions airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
Text,
Box,
Flex,
Divider,
Button,
Checkbox,
Icon,
Expand Down Expand Up @@ -175,6 +174,22 @@ const Logs = ({

return (
<>
{externalLogName && externalIndexes.length > 0 && (
<Box my={1}>
<Text>View Logs in {externalLogName} (by attempts):</Text>
<Flex flexWrap="wrap">
{externalIndexes.map((index) => (
<LogLink
key={index}
dagId={dagId}
taskId={taskId}
executionDate={executionDate}
tryNumber={index}
/>
))}
</Flex>
</Box>
)}
{tryNumber !== undefined && (
<>
<Box>
Expand Down Expand Up @@ -280,25 +295,6 @@ const Logs = ({
)}
</>
)}
{externalLogName && externalIndexes.length > 0 && (
<>
<Box>
<Text>View Logs in {externalLogName} (by attempts):</Text>
<Flex flexWrap="wrap">
{externalIndexes.map((index) => (
<LogLink
key={index}
dagId={dagId}
taskId={taskId}
executionDate={executionDate}
tryNumber={index}
/>
))}
</Flex>
</Box>
<Divider my={2} />
</>
)}
</>
);
};
Expand Down