-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick config statsd host from chart helpers #35679
Conversation
Use the helm chart helpers func to set the default statsd hostname on the metrics config
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM +1
@jedcunningham @hussein-awala @potiuk WDYT?
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This fixes #35678
Use the helm chart helpers func to set the default statsd hostname on the metrics config. This allows the default
values.yaml
of the chart to take into consideration the override of thefullnameOverride
.