Reload configuration for standalone dag file processor #35725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAG file processor has special configuration that is triggered by CONFIG_PROCESSOR_MANAGER_LOGGER variable. The variable is set temporarily when DAG file processor is started as scheduler's subprocess and settings are reloaded because the settings are generally loaded during importing of airflow package, so we need to reload the settings with CONFIG_PROCESSOR_MANAGER_LOGGER set. This did not happen when standalone dag file processor started which led to standalone DAG file processor not producing logs in "dag_processor_manager" folder..
eladkal
approved these changes
Nov 18, 2023
Taragolis
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAG file processor has special configuration that is triggered by CONFIG_PROCESSOR_MANAGER_LOGGER variable.
The variable is set temporarily when DAG file processor is started as scheduler's subprocess and settings are reloaded because the settings are generally loaded during importing of airflow package, so we need to reload the settings with CONFIG_PROCESSOR_MANAGER_LOGGER set. This did not happen when standalone dag file processor started which led to standalone DAG file processor not producing logs in "dag_processor_manager" folder..
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.