Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark daskexecutor provider as removed #35965

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 29, 2023

Following the discussion in airflow devlist we mark daskexecutor as removed. See:
https://lists.apache.org/thread/fxv44cqqljrrhll3fdpdgc9h9fz5ghcy


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Following the discussion in airflow devlist we mark daskexecutor
as removed. See:
https://lists.apache.org/thread/fxv44cqqljrrhll3fdpdgc9h9fz5ghcy
@potiuk potiuk force-pushed the mark-daskexecutor-as-removed branch from ee1ae25 to 12a9e7c Compare November 29, 2023 23:18
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green

@potiuk potiuk merged commit 9c1c9f4 into apache:main Nov 30, 2023
73 checks passed
@potiuk potiuk deleted the mark-daskexecutor-as-removed branch November 30, 2023 13:08
@potiuk
Copy link
Member Author

potiuk commented Nov 30, 2023

ok. Now we just need to release the last one with the "remove" warnings in docs and pypi and then we can remove the code of it completely.

cc: @eladkal -> maybe we can make a separte ad-hoc relese for that one ? Not insisting, it can be done in a next wave as well, but I thought we want to remove it faster. I am even happy to do the release process myself (woudl be a great opportunity to walk through the process again - I have not done it for quite some time).

@eladkal
Copy link
Contributor

eladkal commented Nov 30, 2023

, it can be done in a next wave

Next wave is really close as we are bumping min airflow version for providers today/tommorow

@potiuk
Copy link
Member Author

potiuk commented Nov 30, 2023

Right.... Good timing :)

@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Dec 5, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
Following the discussion in airflow devlist we mark daskexecutor
as removed. See:
https://lists.apache.org/thread/fxv44cqqljrrhll3fdpdgc9h9fz5ghcy

(cherry picked from commit 9c1c9f4)
potiuk added a commit that referenced this pull request Dec 15, 2023
Following the discussion in airflow devlist we mark daskexecutor
as removed. See:
https://lists.apache.org/thread/fxv44cqqljrrhll3fdpdgc9h9fz5ghcy

(cherry picked from commit 9c1c9f4)
@MaiHoangViet1809
Copy link

I know it is late to comment this but we're using DaskExecutor here in production and it quite good, config easier than celery as it not require broker backend like redis.

@potiuk
Copy link
Member Author

potiuk commented Jan 9, 2024

I know it is late to comment this but we're using DaskExecutor here in production and it quite good, config easier than celery as it not require broker backend like redis.

And you can still use it, it will just not be maintained any more by the community. You can keep latest apache-airflow-provider-daskexecutor provider installed in future versions of Airflow and keep using it. No problem with that - it will just not be maintained and tested in the main version of Airflow. We will keep on releasing and fixing security issues (if found) but we will not add new few features and will not keep up with latest dask libraries.

This is possible thanks to implementing "AIP-51 Remove Executor Coupling" https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-51+Removing+Executor+Coupling+from+Core+Airflow - where we designed and implemented public executor API that is intended to be backwards-compatible in the future. Thanks to that, latest released daskexecutor provider https://pypi.org/project/apache-airflow-providers-daskexecutor/ should work with future Airflow versions.

Of course if someone would like to keep on maintaining it, adding new libraries, possibly adding new features, and release a new executor based on the daskexecutor code that we have here tagged - they are absolutely free to do so. Our code is released with Apache Software Licence which allows anyone to do anything with the code and make a fork and release updated provider version on their own. We actually encourage that and will be happy to merge a change with link to such fork to our https://airflow.apache.org/ecosystem/ page where we have multiple providers, plugins, extensions, tools etc. We know also a number of people and teams are working on their own executors (again, following the clean API implemented and published with AIP-51), so having somoene developing and releasing Dask Executor, that someone would like to commit to maintain and release in the future would be one of those.

@vladvisan
Copy link

vladvisan commented Apr 2, 2024

I feel like the following pages could be updated to make it clear that the Dask Executor was discontinued?

  1. https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/dask.html
  2. https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/index.html

I spent some time searching for the DASK Executor install instructions, before realising that it had been removed.
This could avoid this confusion for other people in the future.
Thank you.

@Taragolis
Copy link
Contributor

Page already removed from the "main" branch

Yet still appears on the airflow documentation

This changes will be reflected into Airflow 2.9, as part of #36269

@vladvisan
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants