Fix airflow db shell needing an extra keypress to exit
#35982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzepost
changed the title
airflow db shell needing an extra keypress to exit
potiuk
approved these changes
Nov 30, 2023
|
Fantastic! Thanks @renzepost ! |
renzepost
deleted the
fix_execute_interactive_extra_keypress_after_eof
branch
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit cbb9c4f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #26186
As @blag noted in #26186, pressing Ctrl-D (EOF) to exit the interactive shell requires an additional keypress to actually exit.
It seems that
select.select()was blocking, and setting thetimeoutparameter to 0 fixes the issue of the interactive shell not exiting immediately after pressing Ctrl-D (or typing \q + Enter in psql). The docs for select state:I tested the fix with all the supported db backends and saw no adverse effects, but hopefully someone with more experience with
selectcan tell if this is a reasonable approach.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.