Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dropdown instead of buttons when there are more than 10 retries in log tab #36025

Merged
merged 2 commits into from Dec 3, 2023

Conversation

tirkarthi
Copy link
Contributor

Use dropdown instead of button to select log attempt when there are more than 10 retries.

Less than 10 retries

image

More than 10 retries

image

closes: #35889
related: #35889

Sample dag :

from datetime import datetime, timedelta

from airflow import DAG
from airflow.decorators import task


with DAG(
    dag_id="retry_issue_dag",
    start_date=datetime(2023, 10, 10),
    catchup=False,
    schedule_interval="@once",
) as dag:

    @task(retries=8, retry_delay=timedelta(seconds=1))
    def retry_less_than_10():
        raise Exception("fail")

    @task(retries=15, retry_delay=timedelta(seconds=1))
    def retry_more_than_10():
        raise Exception("fail")

    retry_less_than_10()
    retry_more_than_10()

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 2, 2023
@eladkal eladkal added this to the Airflow 2.8.0 milestone Dec 2, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Dec 2, 2023
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
@potiuk potiuk merged commit fd09883 into apache:main Dec 3, 2023
47 checks passed
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
…n log tab (#36025)

* Use dropdown instead of buttons when there are more than 10 retries in log tab.

* Update airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
(cherry picked from commit fd09883)
@ephraimbuddy ephraimbuddy added type:new-feature Changelog: New Features and removed type:bug-fix Changelog: Bug Fixes labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New logs tab is broken for tasks with high retries
5 participants