Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-asyncio upper-binding limitation #36046

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 4, 2023

Thahnks to our report and bisecting the reason (it was caused by bad handling of the "test*.txt" handling) we can now remove the upper-binding for pytest-asyncio as 0.23.2 version has been released


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Thahnks to our report and bisecting the reason (it was caused by
bad handling of the "test*.txt" handling) we can now remove the
upper-binding for pytest-asyncio as 0.23.2 version has been
released
@potiuk potiuk changed the title Remove pytest-asyncio upper-binding limitatin Remove pytest-asyncio upper-binding limitation Dec 4, 2023
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good investigation in finding root cause

@potiuk potiuk merged commit 55eac5e into apache:main Dec 4, 2023
72 checks passed
@potiuk potiuk deleted the rempve-pytest-asyncio-limit-fixed branch December 4, 2023 10:36
@raphaelauv
Copy link
Contributor

@potiuk
Copy link
Member Author

potiuk commented Dec 4, 2023

pytest-dev/pytest-asyncio#703

Yep. Good to have reference here as well :)

@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Dec 5, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
Thahnks to our report and bisecting the reason (it was caused by
bad handling of the "test*.txt" handling) we can now remove the
upper-binding for pytest-asyncio as 0.23.2 version has been
released

(cherry picked from commit 55eac5e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants