-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bitnami/postgresql subchart to 13.2.24 #36156
Conversation
e546cc0
to
61600f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check the failure in bandit check
it was fixed by #36162 |
072b2b7
to
4a72d38
Compare
Rebased onto |
image: | ||
tag: "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better use specific major Postgres version here, rather than use default from bitnami/postgres subchart.
image:
tag: "16"
16
- referenced to the latest minor version of bitnami/postgresql
of Postgres 16, it is in opposite of 16.1.0-debian-11-r15
which are referenced to the specific major.minor version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review.
There is a good practice to use specific version rather than any sort of latest version as far as I know. Specific version provides better guarantees for deployment to be reproduceable and clear expectations on what exactly should be deployed:
- Two
bitnami/postgresql
deployments with{{ .Values.image.tag }} = 16
might run different database versions. For instance, today it deploys16.1.0-debian-11-r15
, but few days ago16.1.0-debian-11-r13
was deployed with the samevalues.yaml
file. - The deployment with
{{ .Values.image.tag }} = 16
not necessarily runs latest 16 version. For instance, because the chart was deployed a week ago when16.1.0-debian-11-r15
didn't exist. - Fresh deployment with
{{ .Values.image.tag }} = 16
not necessarily runs latest 16 version, because docker image with tag 16 might be presented in host from previous or parallel deployments.
Also, default value from bitnami/postgres
was used before the #29207 where 11 version was pinned to resolve the upgrade issue temporary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differences between minor version of Postgres is a bug fixes include security one, data files are binary compatible between same major version.
So if only pin to the specific version then all users who doesn't care about specify version they would be get one of the first release of 16 Postgres, without fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this only my suggestion, but not strong opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. Let's see what others think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine.. Postrgres chart is only used for testing/dev so we can get the default one.
@potiuk @jedcunningham Could you please have a look at the changes? |
image: | ||
tag: "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine.. Postrgres chart is only used for testing/dev so we can get the default one.
The PR upgrades postgresql dependency of Airflow helm chart:
bitnami/postgresql
subchart upgraded from12.10.0
to13.2.24
PostgreSQL
upgraded fromPostgreSQL 11
toPostgreSQL 16.1.0
(default inbitnami/postgresql:13.2.24
)The change requires
bitnami/postgresql
subchart users (not intended for production) to perform manual major version upgrade using pg_dumpall or pg_upgrade.closes: #34817
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.