New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable native HPA for Airflow Workers #36174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good; I just added a small comment about the chosen type for the HPA metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @pemiranda-clgx
I have one concern regarding versioning.
It should be /v2 for K8S >= 1.23 and /v2beta2 for < 1.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @hussein-awala @amoghrajesh ?
Add K8S native Horizontal Pod Autoscaler in Airflow Workers to support autoscaling based on external custom metrics.