Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase width of execution_date input in trigger.html #36278

Merged

Conversation

HurSungYun
Copy link
Contributor

Description

Currently, the execution_date (or logical date) text on the Trigger page is being truncated due to the width.

This pull request increases the width of the execution_date input to ensure it is fully displayed.

AS-IS

스크린샷 2023-12-18 오후 9 20 30

TO-BE

스크린샷 2023-12-18 오후 9 21 20


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 18, 2023
Copy link

boring-cyborg bot commented Dec 18, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution!

@HurSungYun
Copy link
Contributor Author

@hussein-awala thank you for the review. Is there anything I should do to merge this PR?

@eladkal eladkal added this to the Airflow 2.8.1 milestone Dec 19, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Dec 19, 2023
@eladkal eladkal merged commit aed3c92 into apache:main Dec 19, 2023
51 checks passed
Copy link

boring-cyborg bot commented Dec 19, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala
Copy link
Member

Congrats on your first commit 🎉

samezapple pushed a commit to samezapple/airflow that referenced this pull request Dec 19, 2023
samezapple pushed a commit to samezapple/airflow that referenced this pull request Dec 19, 2023
samezapple pushed a commit to samezapple/airflow that referenced this pull request Dec 20, 2023
potiuk pushed a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Sungyun Hur <ethan0311@gmail.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants