Straighten typing in workday timetable #36296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Just one thing this module also have a twin (I don't know good or evil 🤣 ): tests/plugins/workday.py |
|
Seems like the evil twin only serves to allow more fine grained access to the plugin in unit tests. I’m deduplicating it instead. |
Taragolis
approved these changes
Dec 19, 2023
uranusjr
force-pushed
the
workday-annotation-improve
branch
from
9ed307e
to
a4ce8a3
Compare
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 954bb60)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussions in https://github.com/apache/airflow/pull/36281/files#r1430937442