Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about extending the Airflow helm chart #36331

Merged
merged 2 commits into from Dec 21, 2023

Conversation

shohamy7
Copy link
Contributor

@shohamy7 shohamy7 commented Dec 20, 2023


This PR add docs about how users can extend the Airflow chart easily.
Writing this doc was suggested by @potiuk in the following (closed) PR: #36294
This should resolve the issue: #34399
Resolve: #34399
Instead of adding unnecessary and unrelated templates to our chart, we add a documentation about how the users could do that themselves.

@shohamy7
Copy link
Contributor Author

@potiuk please review, would like to here what you think :)

@shohamy7 shohamy7 force-pushed the add-docs-on-extending-airflow-chart branch from 05aff32 to b6e2bc5 Compare December 20, 2023 12:33
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good start! I think we can add some examples later (or maybe let people contribute the examples) :)

Thanks for doing tit @shohamy7 !

@potiuk
Copy link
Member

potiuk commented Dec 20, 2023

I am all for merging it as-is and then adding incrementally some examples later :)

docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
docs/helm-chart/extending-the-chart.rst Outdated Show resolved Hide resolved
@shohamy7 shohamy7 force-pushed the add-docs-on-extending-airflow-chart branch from 1579d93 to 806de49 Compare December 20, 2023 20:05
@potiuk potiuk merged commit cdddcfc into apache:main Dec 21, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom cronjobs
4 participants