Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics.rst for param dagrun.schedule_delay #36404

Merged
merged 1 commit into from Dec 24, 2023
Merged

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Dec 24, 2023

The timer in statsd client if passed the timedelta, converts into milliseconds rather than seconds.
relates: #33426
closes: #33426


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The timer in statsd client if passed the timedelta, converts into milliseconds rather than seconds.
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM.

@potiuk potiuk merged commit 6199f1f into apache:main Dec 24, 2023
51 checks passed
@eladkal eladkal added this to the Airflow 2.8.1 milestone Dec 25, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Dec 25, 2023
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
The timer in statsd client if passed the timedelta, converts into milliseconds rather than seconds.

(cherry picked from commit 6199f1f)
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
The timer in statsd client if passed the timedelta, converts into milliseconds rather than seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statsd metrics dagrun.schedule_delay sends time in different format against the seconds specified in docs
4 participants