Yet another attempt to fix flakey test_disable_logging test
#36455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Taragolis
added
the
type:misc/internal
potiuk
approved these changes
Dec 27, 2023
|
Let's see. We can merge it and retry the GCP change |
|
Strange thing it only happened in main and not in any PR and I have no idea why yet. But I will also take a look later today to see what difference was there |
potiuk
added
the
full tests needed
|
Reopened with full tests needed |
|
merged. Let's see in main first ad then re-apply the GCP backcompat in main :) |
|
Looks like the fix worked . Good one @Taragolis ! (though we still do not know why it happened :). |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 28, 2023
Remove back-compatibility code for stackdriver now that we are at >= 2.6.0. This caused problems recently with flaky / leaking tests but hopefully apache#36455 fixed the triggering mechanism for that flaky test and this one should succeed now.
potiuk
added a commit
that referenced
this pull request
Dec 28, 2023
Remove back-compatibility code for stackdriver now that we are at >= 2.6.0. This caused problems recently with flaky / leaking tests but hopefully #36455 fixed the triggering mechanism for that flaky test and this one should succeed now.
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
Remove back-compatibility code for stackdriver now that we are at >= 2.6.0. This caused problems recently with flaky / leaking tests but hopefully apache#36455 fixed the triggering mechanism for that flaky test and this one should succeed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one revert approach which was used in #26973 but replaced by
caplogduringunittests->pytestmigration.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.