Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_leaves calculation for teardown in nested group #36456

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix get_leaves calculation for teardown in nested group #36456

merged 1 commit into from
Dec 27, 2023

Commits on Dec 27, 2023

  1. Fix get_leaves calculation for teardown in nested group 

    When arrowing `group` >> `task`, the "leaves" of `group` are connected to `task`. When calculating leaves in the group, teardown tasks are ignored, and we recurse upstream to find non-teardowns.

What was happening, and what this fixes, is you might recurse to a work task that already has another non-teardown downstream in the group.  In that case you should ignore the work task (because it already has a non-teardown descendent).

Resolves apache#36345
    @dstandish
    dstandish committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    5512abb View commit details
    Browse the repository at this point in the history