Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branching based on mapped task group example to dynamic-task-mapping.rst #36480

Merged
merged 3 commits into from Dec 29, 2023

Conversation

RNHTTR
Copy link
Collaborator

@RNHTTR RNHTTR commented Dec 29, 2023

Based on trying to solve this stack overflow question, it seems impossible to reliably branch mapped tasks based on the result of an upstream task. However, it's possible to do this in a mapped task group, which this example demonstrates.

…ing.rst

Based on trying to solve [this stack overflow question](https://stackoverflow.com/questions/77730116/branching-not-working-in-airflow-as-expected/77730300#77730300), it seems impossible to reliably branch mapped tasks based on the result of an upstream task. However, it's possible to do this in a mapped task group, which this example demonstrates.
@potiuk potiuk added this to the Airflow 2.8.1 milestone Dec 29, 2023
@potiuk
Copy link
Member

potiuk commented Dec 29, 2023

Some static checks. Highly recommend to have pre-commit installed :)

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check and address the code linting?

@RNHTTR
Copy link
Collaborator Author

RNHTTR commented Dec 29, 2023

Some static checks. Highly recommend to have pre-commit installed :)

I have it installed; I just tried to sneak one past the tests directly from the browser 😈 😅 . I won't be lazy moving forward.

@potiuk
Copy link
Member

potiuk commented Dec 29, 2023

I have it installed; I just tried to sneak one past the tests directly from the browser 😈 😅 . I won't be lazy moving forward.

Been there, done that :D

@potiuk
Copy link
Member

potiuk commented Dec 29, 2023

Actually ... that makes me think to propose to enable the https://pre-commit.ci/ application for us - which should handle such issues by automatically fixing such PRs.

I think it's in-line with the ASF rules but we will have to ask the ASF infra (and start discussion about it in devlist).

@potiuk
Copy link
Member

potiuk commented Dec 29, 2023

Started discussion about it in https://lists.apache.org/thread/fgoqj23hpl9mlo1n6gfkgvzjxvhfchzm

@potiuk potiuk merged commit 0d9a26c into apache:main Dec 29, 2023
51 checks passed
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Jan 10, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
…ing.rst (#36480)

* Add branching based on mapped task group example to dynamic-task-mapping.rst

Based on trying to solve [this stack overflow question](https://stackoverflow.com/questions/77730116/branching-not-working-in-airflow-as-expected/77730300#77730300), it seems impossible to reliably branch mapped tasks based on the result of an upstream task. However, it's possible to do this in a mapped task group, which this example demonstrates.

* trying to force blacken-docs

(cherry picked from commit 0d9a26c)
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
…ing.rst (apache#36480)

* Add branching based on mapped task group example to dynamic-task-mapping.rst

Based on trying to solve [this stack overflow question](https://stackoverflow.com/questions/77730116/branching-not-working-in-airflow-as-expected/77730300#77730300), it seems impossible to reliably branch mapped tasks based on the result of an upstream task. However, it's possible to do this in a mapped task group, which this example demonstrates.

* trying to force blacken-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants