Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using dict as default value in call_regular_interval #36608

Merged
merged 1 commit into from Jan 5, 2024

Conversation

hussein-awala
Copy link
Member

For more details: #36605 (review)

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case results are missing for failed ones. Can you rerun them?

@eladkal eladkal added this to the Airflow 2.8.1 milestone Jan 5, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@potiuk potiuk merged commit 9f275cf into apache:main Jan 5, 2024
51 checks passed
@hussein-awala
Copy link
Member Author

I just created #36626 to add a Ruff rule to detect the usage of mutable values as argument default values.

@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jan 10, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants