Allow override of hovered navbar colors #36631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncrocfer
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
vchiapaikeo
approved these changes
Jan 6, 2024
|
Indeed this is a good idea to allow the users to customize it too. I check to append a new commit to this PR if you want. |
|
The new 
The default values in the 
|
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
eladkal
force-pushed
the
dev/ncrocfer/navbar_hover
branch
from
26b8a67
to
9dfbf0a
Compare
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Allow override of hovered navbar colors Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com> * Update versions to the next minor release Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com> * Allow override of the logo text color Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com> --------- Signed-off-by: Nicolas Crocfer <ncrocfer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of the #35505 and #35553 ones to customize the navbar color.
When we hover the links with dark colors we can have this behavior with the background color:
With these new settings the user can override the hovered background and text colors:
cc @vchiapaikeo @eladkal @kaxil @jedcunningham
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.