-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show custom instance names for a mapped task in UI #36797
Conversation
I’m thinking the following flow:
We’ll also need a database migration for the new field on TaskInstance. Does this sound reasonable? |
5ab2fde
to
167af3c
Compare
52a4979
to
02ca753
Compare
Also need to look into test failures and static check errors, and fix them. |
Forgot to actually make |
airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx
Outdated
Show resolved
Hide resolved
Some todos after this PR is merged:
|
Hello, I'm new to Airflow and open-source in general, and I'm currently implementing Airflow within my work. I'm very interested in the feature you're working on. Thank you for your contributions! I'd like to ask about the possibility of getting access to this feature before its official release. I understand it may be part of the upcoming Airflow 2.9.0 version, which is currently 83% complete without a set due date. Would it be possible to access the feature by creating a branch from my version of Airflow that includes your changes? I'm still learning the ropes of Git, so any guidance on the feasibility of this would be greatly appreciated. If this approach is possible, I'm happy to test the feature and provide feedback. |
Sure but it is does not come with any guarantees whatsoever, it might break any time and if it breaks it might stay broken for a long time. However if you will, you can definitely run airflow locally from latest main and if you see any issues, you can even fix them via PR (this is what most people contributing here are doing). You can follow contribution flow -> see https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst as an entry point - then you have local virtualenv or Also for that you need to learn git and branching etc. based on the contributing guide, there is an expectation that you know what you are doing there. There is no other "approach" that allows you to run things which are not released officially in production. Whatever we do here is purely for development and contribuion purposes. If you want to be exclusively a user, then releasing the software is a Legal Act of the Apache Software Foundation, and only then when the software is formally released and there are 3 binding +1 votes from the PMC members, the software we release should be used by the users who are not contributors. This has legal, licencing implications and even if we would like to, we cannot ever say that whatever we have in the repo is "usable" by users. It's usable to do contributions. Full stop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI parts look good to me. We can go through and find more areas where we want to show rendered map index in a follow-up PR.
Are migrations being worked on in another PR? This breaks main branch testing for me since rendered_map_index doesn't have migration.
|
Migration PR in #37708 |
Thank you! This is what I was missing, specially the how to contribute. I will take a look |
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.