Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix successful Apache Druid task submissions reported as failed #36813

Merged
merged 6 commits into from Jan 24, 2024

Conversation

listik
Copy link
Contributor

@listik listik commented Jan 16, 2024

Apache Druid returns status code 202 Approved on successful MSQ requests, but the hook is only checking for a 200 status code.

This means MSQ ingestions are reported as failed by default, despite being successfully executed by the Druid service.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jan 16, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jan 16, 2024

Could you please add a unit test covering it?

@listik
Copy link
Contributor Author

listik commented Jan 17, 2024

Could you please add a unit test covering it?

Hey @potiuk, I thought this unit test was already covering the submit_indexing_job() hook method?

@potiuk
Copy link
Member

potiuk commented Jan 21, 2024

Hey @potiuk, I thought this unit test was already covering the submit_indexing_job() hook method?

Apparently it does not test what it should then. If you make a change fixing a problem and there is no test that fails before and get fixed after the change, it means that the error case has not been tested.

@listik listik requested a review from dirrao January 22, 2024 12:25
@potiuk potiuk merged commit 5c4364a into apache:main Jan 24, 2024
54 checks passed
Copy link

boring-cyborg bot commented Jan 24, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Jan 24, 2024

Thanks for adding the test!

@listik
Copy link
Contributor Author

listik commented Jan 24, 2024

Thanks for adding the test!

Thank you for the feedback and patience!

@listik listik deleted the apacheDruidSuccessCode branch January 24, 2024 09:12
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
…he#36813)

* Accept 202 status code response

* Fix status message

* Addresses [comment](apache#36813 (comment))

* Make tests cover actual behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants