Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GKEStartJobOperator and KubernetesJobOperator #36847

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Create GKEStartJobOperator and KubernetesJobOperator #36847

merged 8 commits into from
Feb 15, 2024

Conversation

MaksYermak
Copy link
Contributor

In this PR I have created operators for starting Kubernetes Job in clusters(ordinary and GKE).

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests kind:documentation provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues labels Jan 17, 2024
hussein-awala
hussein-awala reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge/rebase main?

@eladkal
Copy link
Contributor

eladkal commented Jan 17, 2024

There was a discussion about this capability in #17490

@MaksYermak
Copy link
Contributor Author

Could you merge/rebase main?

Sure, I have rebased the branch.

@raphaelauv
Copy link
Contributor

👍

would be great to also add some doc there -> #36847

like KPO vs KOJ ...

@eladkal eladkal mentioned this pull request Jan 21, 2024
Closed
@dirrao
Copy link
Collaborator

dirrao commented Feb 1, 2024

👍

would be great to also add some doc there -> #36847

like KPO vs KOJ ...

Yes. It would be great to document when to prefer KJO over KPO.

@MaksYermak MaksYermak force-pushed the gke-start-job-operator branch 2 times, most recently from 7e6deac to f9dd537 Compare February 6, 2024 15:45
@MaksYermak
Copy link
Contributor Author

@dirrao @raphaelauv @hussein-awala I have updated documentation for KubernetesJobOperator. Could you review my PR one more time?

@VladaZakharova
Copy link
Contributor

Hi @eladkal !
Could you please take a look on these changes? Thanks!

@potiuk
Copy link
Member

potiuk commented Feb 15, 2024 •
edited

Hey @VladaZakharova @MaksYermak - can you rebase please? Conflicts got in the way after I merged #37072

@MaksYermak
Copy link
Contributor Author

MaksYermak commented Feb 15, 2024 •
edited

Hey @VladaZakharova @MaksYermak - can you rebase please? Conflicts got in the way after I merged #37072

Hi @potiuk , I have rebased the branch.

@potiuk potiuk merged commit 32ba99b into apache:main Feb 15, 2024
63 checks passed
This was referenced Feb 17, 2024
Closed
Closed
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
@MaksYermak @sunank200
Create GKEStartJobOperator and KubernetesJobOperator (apache#36847)
f786d43
@eladkal eladkal mentioned this pull request Mar 4, 2024
Closed
79 tasks
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
@MaksYermak @abhishekbhakat
Create GKEStartJobOperator and KubernetesJobOperator (apache#36847)
ae3a7fa
@moiseenkov moiseenkov mentioned this pull request Mar 5, 2024
Closed
@bmoon4 bmoon4 mentioned this pull request May 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussein-awala hussein-awala hussein-awala left review comments

@potiuk potiuk potiuk approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
area:providers area:system-tests kind:documentation provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MaksYermak @eladkal @raphaelauv @dirrao @VladaZakharova @potiuk @hussein-awala