Add more precise description on avoiding generic package/module names #36927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading.
potiuk
force-pushed
the
add-more-precise-descriptin-on-generic-python-packages-modules
branch
from
5a176f1
to
61ab4bd
Compare
potiuk
deleted the
add-more-precise-descriptin-on-generic-python-packages-modules
branch
flacode
pushed a commit
to flacode/airflow
that referenced
this pull request
Jan 22, 2024
…apache#36927) It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading.
jedcunningham
pushed a commit
that referenced
this pull request
Feb 9, 2024
…#36927) It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading. (cherry picked from commit 06dc1dd)
potiuk
added a commit
that referenced
this pull request
Feb 13, 2024
…#36927) It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading. (cherry picked from commit 06dc1dd)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
…#36927) It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading. (cherry picked from commit 06dc1dd)
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…apache#36927) It's more and more happening recently that users start to put generic package and module names directly at ``PYTHONPATH`` which overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works. The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more and more happening recently that users start to put generic package and module names directly at
PYTHONPATHwhich overrides the stdlib or airflow imports. Adding a more detailed description should help in just directing people to that page where they can learn how Python module loading works.The chapter name is changed to "Best practices for your code namig", because the problem is whit naming, not loading.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.