Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore the internal_ip_only if set to false in Dataproc cluster config #37014

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

ahzaz
Copy link
Contributor

@ahzaz ahzaz commented Jan 25, 2024


Dataproc is changing the default value of internal_ip_only configuration starting image version 2.2. If user passes the property value as false, it is ignored. This can lead to different behavior for different Dataproc image versions.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 25, 2024
@ahzaz ahzaz changed the title Do not default to False for internal_ip_only for Dataproc cluster configuration Do not ignore the internal_ip_only if set to false in Dataproc cluster config Jan 25, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the test cases for this change?

@ahzaz
Copy link
Contributor Author

ahzaz commented Jan 31, 2024

@dirrao Added tests

@potiuk potiuk merged commit 4150314 into apache:main Jan 31, 2024
54 of 55 checks passed
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants