Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify hive client connection #37043

Merged
merged 10 commits into from Feb 4, 2024
Merged

Conversation

romsharon98
Copy link
Collaborator

@romsharon98 romsharon98 commented Jan 27, 2024

related: #36221

motivation:
as mention in docs today it's not intuitive to use proxy user in HiveOperator. this pr remove the options to set proxy user according to owner or login while keeping the option to set proxy user in the connection, although make it easier to set proxy_user with just sending it as parameter to the operator:

HiveOperator(task_id="test_default_config_queue",proxy_user="dummy user"..)

also this pr move the extra parameters to independent cell in hive client connection and make it more friendly.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal changed the title Feature make hive client connection simpler Simplify hive client connection Jan 28, 2024
@romsharon98 romsharon98 marked this pull request as ready for review January 28, 2024 11:34
@romsharon98 romsharon98 marked this pull request as draft January 28, 2024 11:35
@romsharon98 romsharon98 marked this pull request as ready for review January 28, 2024 16:12
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airflow/providers/apache/hive/CHANGELOG.rst Outdated Show resolved Hide resolved
@eladkal eladkal merged commit caec4c7 into apache:main Feb 4, 2024
56 checks passed
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
* change hive proxy user

* remove extra from connection

* change documentation

* add breaking change and change version

* fix spell check

* fix docs

* Update airflow/providers/apache/hive/CHANGELOG.rst

* fix typo

* proxy user sent in operator will override proxy user in connection

* fix change log

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants