Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hook.wait_for_operation in DataprocInstantiateInlineWorkflowTemplateOperator #37145

Conversation

edin-tapad
Copy link
Contributor

@edin-tapad edin-tapad commented Feb 2, 2024

We ran into an issue when running a long Dataproc job with DataprocInstantiateInlineWorkflowTemplateOperator. It seems that hook.wait_for_operation should be used so that the timeout parameter is passed to operation.result() properly.

The error we were getting:

concurrent.futures._base.TimeoutError: Operation did not complete within the designated timeout of 900 seconds.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 2, 2024
Copy link

boring-cyborg bot commented Feb 2, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@edin-tapad edin-tapad force-pushed the use-wait_for_operation-in-DataprocInstantiateInlineWorkflowTemplateOperator branch 2 times, most recently from bd7d697 to 9fbf861 Compare February 2, 2024 11:05
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the test case for the change?

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@edin-tapad edin-tapad force-pushed the use-wait_for_operation-in-DataprocInstantiateInlineWorkflowTemplateOperator branch from 9fbf861 to fc03f8b Compare February 2, 2024 16:14
@potiuk potiuk merged commit 028fbdf into apache:main Feb 12, 2024
56 checks passed
Copy link

boring-cyborg bot commented Feb 12, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants