Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shutdown color to the STATE_COLORS #37295

Merged
merged 5 commits into from Feb 10, 2024

Conversation

Satoshi-Sh
Copy link
Contributor

Issue

When you go to the /cluster_activity page, you will see the warning. " The color for shutdown is missing from the palette, defaulting to black. "

Screenshot from 2024-02-09 14-39-03

Updates

Added shutdown color to the STATE_COLORS. You will not see the warning anymore.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

airflow/settings.py Outdated Show resolved Hide resolved
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
@dirrao
Copy link
Collaborator

dirrao commented Feb 10, 2024

Some unrelated tests are failing. closing and reopening PR to rerun the tests.

@dirrao dirrao closed this Feb 10, 2024
@dirrao dirrao reopened this Feb 10, 2024
@Taragolis
Copy link
Contributor

Need also fix the failing test by replace this line

'"scheduled": "tan", '

to

'"scheduled": "tan", "shutdown": "blue", '

@hussein-awala hussein-awala merged commit 1623a6a into apache:main Feb 10, 2024
56 checks passed
@Satoshi-Sh Satoshi-Sh deleted the fix/shutdown-missing-color branch February 10, 2024 23:28
@ephraimbuddy ephraimbuddy added this to the Airflow 2.9.0 milestone Feb 19, 2024
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Feb 19, 2024
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
* Added shutdown color to the STATE_COLORS

* Changed the shutdown color to blue.

Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>

* Updated test

---------

Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
* Added shutdown color to the STATE_COLORS

* Changed the shutdown color to blue.

Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>

* Updated test

---------

Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants