Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer token as authentication method to GoogleAdsHook #37417

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

LeonGraveland
Copy link
Contributor

@LeonGraveland LeonGraveland commented Feb 14, 2024


This PR is the result of #30954

It adds a extra method of authenticating with google ads using the GoogleAdsHook. It only requires one connection containing a persistent developer token with credentials. Docs on how to get a developer token can be found here

It is implemented in a way that it determines the way of authentication by the contents in the 'extra' field of the google ads connection.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 14, 2024
Copy link

boring-cyborg bot commented Feb 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@LeonGraveland LeonGraveland marked this pull request as draft February 14, 2024 11:09
@LeonGraveland LeonGraveland force-pushed the feature-developer-token-google-ads branch 3 times, most recently from f46d015 to 3e14370 Compare February 14, 2024 13:00
@LeonGraveland LeonGraveland marked this pull request as ready for review February 14, 2024 13:19
@LeonGraveland LeonGraveland force-pushed the feature-developer-token-google-ads branch 4 times, most recently from 2e50ed0 to 2822aff Compare February 14, 2024 17:53
airflow/providers/google/ads/hooks/ads.py Outdated Show resolved Hide resolved
airflow/providers/google/ads/hooks/ads.py Outdated Show resolved Hide resolved
@LeonGraveland LeonGraveland force-pushed the feature-developer-token-google-ads branch from f7799ee to 947e314 Compare February 15, 2024 14:27
@potiuk potiuk merged commit 107b3e2 into apache:main Feb 15, 2024
58 checks passed
Copy link

boring-cyborg bot commented Feb 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
…#37417)

* Add developer token as authentication method to GoogleAdsHook

* Refactor method name and if statement

---------

Co-authored-by: Leon Graveland <leon.graveland@justeattakeawway.com>
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
…#37417)

* Add developer token as authentication method to GoogleAdsHook

* Refactor method name and if statement

---------

Co-authored-by: Leon Graveland <leon.graveland@justeattakeawway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants