Core tests fail when run separately #37467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drajguru
changed the title
potiuk
requested changes
Feb 16, 2024
There was a problem hiding this comment.
As discussed in the issue, likely the assesment was based on the previous version of the test, that indeed monkeypached SQL_ALCHEMY_SETTINGS permanently for the rest of Pytest session and initalized other settings components as side-effect. - but #37320 just few days ago fixed exactly this problem.
The issue mentioned in the issue description does not seem to occur any more.
Requesting changes until it's clarified by the author.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add orm mocking to settings test
Prevent putting the session into a state that prevents subsequent test modules from passing.
closes: #37466