New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Datasets by associated dag_ids (GET /datasets) #37512
Filter Datasets by associated dag_ids (GET /datasets) #37512
Conversation
I wonder if it’s clear enough to call this just |
dag_ids could be from consuming_dags and producing_tasks. We could have 2 queries for |
My use case is that I want any datasets connected to a single dag. But I am indifferent if that is a single param |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "request changes" to make sure we don't accidentally merge.
I think having both makes sense. In your use case, if we only had consuming/producing, you'd have to hit the endpoint twice (they'd be AND'd together, not OR'd). So maybe we start with the simple |
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works great. Thanks for picking this up!
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Description
Added dag_ids query to the
GET /datasets
endpoint. Updated document and unit test accordingly.Related Issue
closes #37423
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.