-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use offset-naive datetime in _CredentialsToken #37539
Conversation
The field `access_token_acquired_at` is specific to gcloud-aio's Token class and will be used on subsequent calls of `get` with an offset-naive datetime insternally. Therefore we cannot use offset-aware instances of datetime here.
9c45881
to
08ab9ec
Compare
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Let others know about things to consider when upgrading the major version of gcloud-aio-auth.
@@ -89,6 +89,12 @@ dependencies: | |||
- apache-airflow>=2.6.0 | |||
- apache-airflow-providers-common-sql>=1.7.2 | |||
- asgiref>=3.5.2 | |||
# When upgrading the major version of gcloud-aio-auth we want to make sure to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something block us from upgrading version now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, no. I suppose a bit more care is needed when doing so, as it affects a range of async code of the provider. Also not sure yet how it affects the other gcloud-aio packages.
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
The field
access_token_acquired_at
is specific to gcloud-aio's Token class and will be used on subsequent calls ofget
with an offset-naive datetime insternally. Therefore we cannot use offset-aware instances of datetime here.related: #37138
@Taragolis
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.