-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries to job heartbeat #37541
Add retries to job heartbeat #37541
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should split the retries - separately for fetch and separately for update
I would love to have some more reviews on that one - to see if no-one can see a side effect (I believe it is safe to retry on the level of those methods. |
Anyone :) ? |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Job heartbeat retries * Tweak format * Retry on individual db operations
* Job heartbeat retries * Tweak format * Retry on individual db operations
* Job heartbeat retries * Tweak format * Retry on individual db operations
Add retries to Job.heartbeat to avoid job SIGTERM due to intermittent/transient database issues. Raised in #37378