Clean up webserver endpoints adding to audit log #37580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
bbovenzi
commented
Feb 21, 2024
jedcunningham
requested changes
Feb 21, 2024
Lee-W
approved these changes
Feb 22, 2024
jedcunningham
approved these changes
Feb 22, 2024
|
Looks like there might be a couple test failures from this change. |
uranusjr
approved these changes
Feb 22, 2024
|
Specifically |
Fixed. Removed two unneeded tests and added a test for robots.txt |
jedcunningham
approved these changes
Feb 22, 2024
|
@jedcunningham For some reason |
jedcunningham
approved these changes
Feb 23, 2024
bbovenzi
force-pushed
the
fix-webserver-logging
branch
from
714975b
to
2664251
Compare
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Clean up webserver endpoints adding to audit log * Remove all view-only action logging and change excluded events list * Restore robots logging * Remove two extra loggings+tests, add test for robots.txt * Fix rendered template test
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Clean up webserver endpoints adding to audit log * Remove all view-only action logging and change excluded events list * Restore robots logging * Remove two extra loggings+tests, add test for robots.txt * Fix rendered template test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only log webserver events that are CRUD actions. View-only endpoints shouldn't be logged. Therefore we don't need any default excluded events.
Removed a few other unused decorators, mostly on on redirect functions.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.