Show dataset events above task/run details in grid view #37603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
Sure. Updated! |
jedcunningham
approved these changes
Feb 22, 2024
sudiptob2
pushed a commit
to Satoshi-Sh/airflow
that referenced
this pull request
Feb 22, 2024
* Show dataset events above task/run details in grid view * Add extra to dataset event tables
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Show dataset events above task/run details in grid view * Add extra to dataset event tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we had dataset events linked to a task instance or dag run below all of the details. It is too easy to miss that information, especially since those details contain a lot more information. Now all datasets are above all of the task/run metadata.
Also, broke up each section into its own component to keep our files smaller.
Before (scrolled to the bottom of the page):
After:
I think we can still improve the extra link and notes UI so they take up less vertical space.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.