Modify ssl verification in druid operator #37673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:danielbe11/airflow into modify-ssl-verification-in-druid-operator
dirrao
suggested changes
Feb 25, 2024
|
@dirrao the backwards compatibility and get_verify method are tested, I will add a small test for 'conn' method today |
I have added |
eladkal
approved these changes
Mar 3, 2024
79 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Use cached_property for get_connection to avoid calling >1 * Get ca bundle path from connection config if not verifying ssl * Add type checking check * Add tests * Fix lint and add documentation * Use default * Final tidy * Add log for when using CA bundle * Add test_conn_property --------- Co-authored-by: Daniel Bell <daniel.bell@skyscanner.net>
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Use cached_property for get_connection to avoid calling >1 * Get ca bundle path from connection config if not verifying ssl * Add type checking check * Add tests * Fix lint and add documentation * Use default * Final tidy * Add log for when using CA bundle * Add test_conn_property --------- Co-authored-by: Daniel Bell <daniel.bell@skyscanner.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extraproperty of the Druid connection is checked forverifykey which can be set as the path to CA bundle.self.get_connection(self.druid_ingest_conn_id)which is called >1 times.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.