Add Dag Audit Log to React #37682
Merged
Add Dag Audit Log to React #37682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
dirrao
approved these changes
Feb 25, 2024
eladkal
approved these changes
Feb 25, 2024
potiuk
approved these changes
Feb 25, 2024
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Initial audit log page * Improve tab logic, add filters to audit log
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Initial audit log page * Improve tab logic, add filters to audit log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue modernizing the UI. Use the REST API show the Audit Log for a DAG in react.
The Audit Log shows up as a tab for every selection (dag, dag run, task, task instance). And we try to filter the Audit Log accordingly, within the limitations we have at least.
Run ID isn't recorded and execution date is not currently a parameter (nor do we always record the execution date or map index anyway). So instead when there is a dag run, we filter the before/after dates to the queued at and last scheduling decision dates.
Also cleaned up the logic of what tabs to default to when changing selection.
Task Instance Selected (filtered by before, after and task id)
Task is selected (filtered by task id)
Nothing selected (only filtered by dag id)
Dag Run selected (filtered by before and after)
ToDo in later PRs:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.