Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all unique run_ids render a task duration bar #37717

Merged
merged 1 commit into from Feb 27, 2024

Conversation

bbovenzi
Copy link
Contributor

Before, we were only rendering each bar of the bar graph of task durations based on unique ordering but manual dag runs can have the same data interval start/end. Instead, we should show a duration bar for every runId.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 26, 2024
@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Feb 26, 2024
@bbovenzi
Copy link
Contributor Author

cc: @tirkarthi

@tirkarthi
Copy link
Contributor

Initially the dimension was an array of ["runId", "duration"]. It was changed to orderingLabel since there was some mismatch in the order of grid view and task duration graph entries. I forgot the exact reason but does this introduce back any discrepancy in the order between grid and task duration?

@bbovenzi
Copy link
Contributor Author

Initially the dimension was an array of ["runId", "duration"]. It was changed to orderingLabel since there was some mismatch in the order of grid view and task duration graph entries. I forgot the exact reason but does this introduce back any discrepancy in the order between grid and task duration?

The order we get from useGridData is the same since its sorted in the webserver so it should be fine as long as we don't try to sort it again in the UI.

@bbovenzi bbovenzi merged commit cd31715 into apache:main Feb 27, 2024
56 checks passed
@bbovenzi bbovenzi deleted the fix-task-duration-bars branch February 27, 2024 03:29
@vatsrahul1001
Copy link
Collaborator

thanks @bbovenzi verified this working fine now

image

abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 6, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants