-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme Update #37727
Readme Update #37727
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@@ -180,15 +180,13 @@ them to the appropriate format and workflow that your tool requires. | |||
|
|||
|
|||
```bash | |||
pip install 'apache-airflow==2.8.2' \ | |||
--constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.8.2/constraints-3.8.txt" | |||
pip install 'apache-airflow==2.8.2' --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.8.2/constraints-3.8.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected. However, you might have added additional space after \
causing the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only know such a problem into the PowerShell. Most possible @hamad-tariq tried to install Airflow on Windows Host. Am I right? If so, I want to mention that there is no official support of Windows yet (and no plan in foreseeable future), see: #10388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sounds isolated. Let's leave it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I agree, let's leave it as is.
I'm going to close this PR now, but thanks @hamad-tariq. I hope to see more docs PRs from you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jedcunningham for the appreciation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my experience, I had tried the existing command multiple times with the \
but it only worked when I removed the \
. So I decided to correct it up for others so that they can directly use the given command on the Windows CLI and not run with any errors as I did. However, It'll be great if we can add both the commands with clear instructions of when to use which one of them so that if someone faces an error or problem they have the can find a solution right away with in the official documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If you can propose a description of that kind, that is a better PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just need to make sure you describe the right circumstances and explain what's going on - and you are likely the best person to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I guess that's a better approach to expand the content of the documentation than replacing something in the it. Thanks to all the members for the feedback.
The PyPI installation command was not working when I tried to install Apache Airflow on my local machine with the given bash command.
Error Message
Solution
Updated the bash command to be executed in a single line.
Old
New