Inherit the run_ordering from DatasetTriggeredTimetable for DatasetOrTimeSchedule #37775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
force-pushed
the
add_reordering_crontrigger_timetable
branch
from
7de5aa9
to
de3e6e5
Compare
|
Why do we want to change it on CronTrigger instead of on |
|
|
@uranusjr Does this make sense to you? |
sunank200
force-pushed
the
add_reordering_crontrigger_timetable
branch
from
de3e6e5
to
4c43885
Compare
sunank200
changed the title
dirrao
reviewed
Feb 29, 2024
sunank200
force-pushed
the
add_reordering_crontrigger_timetable
branch
from
4c43885
to
16f7f02
Compare
sunank200
changed the title
sunank200
changed the title
sunank200
force-pushed
the
add_reordering_crontrigger_timetable
branch
from
16f7f02
to
54c1791
Compare
|
@sunank200 tested, LGTM |
uranusjr
approved these changes
Feb 29, 2024
|
nice job finding the problem @sunank200 |
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_orderingfromDatasetTriggeredTimetableforDatasetOrTimeSchedule^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.