Remove provide_session decorator from TaskInstancePydantic methods #37853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we decorate these methods then the worker will try to create a session. But there's no reason to do this. Sessions should be created on the static methods invoked by the API server right?
potiuk
approved these changes
Mar 3, 2024
|
Correct. Those should be removed. |
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…pache#37853) If we decorate these methods then the worker will try to create a session. But there's no reason to do this. Sessions should be created on the static methods invoked by the API server right?
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…pache#37853) If we decorate these methods then the worker will try to create a session. But there's no reason to do this. Sessions should be created on the static methods invoked by the API server right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we decorate these methods then the worker will try to create a session. But (I think...) there's no reason to do this. Sessions should be created on the static methods invoked by the API server right?