@task.bash warn only if multiple_outputs=True
#37875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've thinking maybe it is also a good idea to explicit provide into the |
uranusjr
reviewed
Mar 4, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Mar 4, 2024
dirrao
approved these changes
Mar 5, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* `@task.bash` warn only if `multiple_outputs=True` * Update airflow/decorators/bash.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * Add explicit multiple_outputs=False * Add explicit UserWarning category --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small side effect with warnings after #37297.
@task.bashconstantly warns even ifmultiple_outputsdoesn't setIn addition change stack level to show in which file this decorator use
stacklevel=1
/opt/airflow/airflow/models/baseoperator.py:445 UserWarning: `multiple_outputs=True` is not supported in @task.bash tasks. Ignoring.stacklevel=3
/files/dags/sample_bash.py:14 UserWarning: `multiple_outputs=True` is not supported in @task.bash tasks. Ignoring.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.