Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless methods from security manager #37889

Merged
merged 2 commits into from Mar 6, 2024

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Mar 4, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 4, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failing due to references to deleted functions.

@vincbeck
Copy link
Contributor Author

vincbeck commented Mar 5, 2024

Checks are failing due to references to deleted functions.

Fixed ;)

@potiuk potiuk merged commit fd4dfd8 into apache:main Mar 6, 2024
59 checks passed
@utkarsharma2 utkarsharma2 added this to the Airflow 2.8.3 milestone Mar 6, 2024
@utkarsharma2 utkarsharma2 added type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Mar 6, 2024
ephraimbuddy pushed a commit that referenced this pull request Mar 6, 2024
* Remove useless methods from security manager

* Fix mypy

(cherry picked from commit fd4dfd8)
@vincbeck vincbeck deleted the vincbec/security_manager_clean branch March 6, 2024 16:11
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Remove useless methods from security manager

* Fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants