Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendar view to react #37909

Merged
merged 4 commits into from Mar 7, 2024
Merged

Add calendar view to react #37909

merged 4 commits into from Mar 7, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 5, 2024

Continue to modernize the UI by building the calendar view in React. The tab is visible when a user has no run or task selected in the grid view.

Next up, I will delete the old page and redirect to this tab.

Screenshot 2024-03-05 at 1 49 49 PM

Monthly DAG:
Screenshot 2024-03-05 at 1 50 30 PM

Tooltip:
Screenshot 2024-03-05 at 1 50 14 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Mar 5, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 5, 2024
@bbovenzi
Copy link
Contributor Author

bbovenzi commented Mar 5, 2024

Also fixes: #37902

@eladkal eladkal linked an issue Mar 5, 2024 that may be closed by this pull request
2 tasks
@potiuk
Copy link
Member

potiuk commented Mar 6, 2024

Fantastic!

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

As it might be confusing that the old calendar is top-down and the new one is bottom-up in ordering of the years... can you remove the old one prior 2.9.0 release cut?

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Mar 6, 2024

Cool!

As it might be confusing that the old calendar is top-down and the new one is bottom-up in ordering of the years... can you remove the old one prior 2.9.0 release cut?

Yes, my intention is to remove all of these legacy pages in time for 2.9

@phanikumv phanikumv merged commit 354e633 into apache:main Mar 7, 2024
57 checks passed
@phanikumv phanikumv deleted the react-calendar branch March 7, 2024 02:09
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 14, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar view infinite loop for @continuous DAGs
5 participants