New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TaskFail entries to Gantt chart #37918
Add TaskFail entries to Gantt chart #37918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool!
I am not sure whethere the current implementation has a small "refresh problem", tested with my firefox and a task with multiple retires. While running and waiting and taking a look while it was running looked like this:
...but my test had 5 attempts/4 fails:
..then flipping back still th same, but after hitting F5 then finally screen is updated with all attempts:
Is this a local browser caching problem? Or a small glitch/bug in refresh?
Noticed that also flipping gantt to another dag run and back does not help. I really need to hit F5 to get the right/final update.
Another glitch that I found - but this might be data related? If I "clear" a task in UI forcing a re-run, I do not see previous runs of the task in the gantt - might it be that that is not captured in task_tries
table when clearing? (Alongside with the scheduling delay which is always shown for last execution only.
Bye the way as being on the Gantt view I noticed that probably the bug report in #37935 is correct - whenever using the example_bash_operator
as example DAG to test I needed to reload the gantt to get the new DAG run published after trigger. If I am starting to trigger from Grid view this is always automatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
c640b39
to
febee38
Compare
Added autorefresh to fetching Task Fails. I noticed that redirect bug and I'll work on that separately. |
Nice! |
* Add TaskFail entries to Gantt chart * Fix some autorefresh
* Add TaskFail entries to Gantt chart * Fix some autorefresh
* Add TaskFail entries to Gantt chart * Fix some autorefresh
If we're going to have a
TaskFail
table. Then let's use it. Before it was only used in the old Task Duration table, but that didn't give a user a good sense of their Task Instance. Instead, using it in the Gantt chart can tell more about how a dag run occurred.Before. Can only see the final task instance try:
After. Can see all previous task instances failures. Notice how TryNumber = 6 and there are 6 bars in the chart:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.