Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all old dag pages and redirect to grid view #37988

Merged
merged 10 commits into from Mar 25, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 8, 2024

All of the DAG pages are in React now, so we can delete the old FAB templates and redirect the urls to the grid view and appropriate tab. This removes extraneous vertical space on the page too.

Landing Times -> Run Duration
Task Duration -> Task Duration
Audit Log -> Audit Log
Calendar -> Calendar
Task Tries -> Grid (this never made sense as a line chart, instead try_number is displayed in more places)

Before:
Screenshot 2024-03-07 at 9 54 57 PM

After:
Screenshot 2024-03-07 at 9 54 38 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 8, 2024
@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Mar 8, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whohooo! Cool! Finally! (I just need to get used to the "missing top bar" - so much more space on the screen - but will take a moment until I take the new alternative buttons.

I'd approve but have a small request for consistency of beautification: There are 3,5 screens leftover in the old structure:
image

  • Grid/Task Details --> More Details (still pointing to a legacy view, which actually is just a small leftover to migrate... wanted to contribute this but never came out of my backlog :-()
  • Grid/Task Details --> Rendered Template (same here)
  • Grid/Logs --> See more

If you click on any of these you end-up on the legacy view with the leftovers, still there is a top navigation, besides the browser back button there is no way to "officially" get back to Grid view. Also the legacy XCom is these.
image

Can you please add a button to get back to Grid view?
Would it make sense to drop the XCom view here as well? The new one is there anyway.
(Alternatively, wouls it be simple to migrate at elast the two "More Details/Rendered Template" also into React? Old Log view might stay there, at least I am a fan of the full screen option still from old times... sometimes logs in Grid are too small)

@bbovenzi
Copy link
Contributor Author

Alternatively, would it be simple to migrate at elast the two "More Details/Rendered Template" also into React? Old Log view might stay there, at least I am a fan of the full screen option still from old times... sometimes logs in Grid are too small)

Yes, I need to add rendered templates to React and then remove these pages too.
And I need to do more "Full screen" views.

@jscheffl
Copy link
Contributor

Ready to test to get it into 2.9.0?

@bbovenzi bbovenzi marked this pull request as ready for review March 18, 2024 17:44
@bbovenzi
Copy link
Contributor Author

Ready to test to get it into 2.9.0?

Yep! Ready for review now.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that the last two pages are also replaced with the last commit as notes in #37988 (review) - but LGTM before having this waiting until 2.10 - leftovers can also be made in a follow-up PR...

@bbovenzi
Copy link
Contributor Author

I was hoping that the last two pages are also replaced with the last commit as notes in #37988 (review) - but LGTM before having this waiting until 2.10 - leftovers can also be made in a follow-up PR...

Which last two pages are you referring to? Finishing off the task specific ones like rendered_templates? That will be a follow-up PR.

@potiuk
Copy link
Member

potiuk commented Mar 20, 2024

As discussed with @bbovenzi -> removal of "Required" dependencies is not as easy due to caching.

#38312 adds mechanism to do so

@bbovenzi
Copy link
Contributor Author

As discussed with @bbovenzi -> removal of "Required" dependencies is not as easy due to caching.

#38312 adds mechanism to do so

Thanks! I'll do that in a follow-up PR

@dstandish
Copy link
Contributor

dstandish commented Mar 20, 2024

@bbovenzi i think this one really wants a news fragment.

some users are gonna be "where did my buttons go???"

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

airflow/www/views.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 25, 2024
@bbovenzi bbovenzi merged commit e6e5fdb into apache:main Mar 25, 2024
45 checks passed
@bbovenzi bbovenzi deleted the remove-legacy-dag-pages branch March 25, 2024 15:11
@jscheffl
Copy link
Contributor

Finally.. WOHOOO! Thanks!

utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Delete all old dag pages and redirect to grid view

* Fix linting

* Fix session

* Relax type to appease Mypy

* cleanup dagjs and forward audit log params

* Remove nvd3

* Remove python nvd3 in a separate pr

* newsfragment

* Fix static check in main

* remove extraneous auth checks

---------

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants