Show if dag page filters are active #38080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
jscheffl
reviewed
Mar 12, 2024
jscheffl
approved these changes
Mar 13, 2024
|
Moved the Number of Runs input to be separate from the real filters: 
|
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
* Show users when Dag page filters are active * keep border color on hover * Clear filter button only for baseDate,runType,runState * Make number of runs separate from filters
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 18, 2024
* Show users when Dag page filters are active * keep border color on hover * Clear filter button only for baseDate,runType,runState * Make number of runs separate from filters
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 31, 2024
* Show users when Dag page filters are active * keep border color on hover * Clear filter button only for baseDate,runType,runState * Make number of runs separate from filters
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Show users when Dag page filters are active * keep border color on hover * Clear filter button only for baseDate,runType,runState * Make number of runs separate from filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not always obvious that we have active filters on the DAG page. We should make it more obvious so users are less confused.
Clear button is disabled if no filters:
Clear button is active and the active filter has a blue border color:
Also a minor styling fix (before and after):
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.