-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix region
argument in MappedOperator
based on AwsBaseOperator
/ AwsBaseSensor
#38178
Merged
+149
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
AWS/Amazon - related issues
labels
Mar 15, 2024
eladkal
approved these changes
Mar 15, 2024
eladkal
reviewed
Mar 15, 2024
Taragolis
commented
Mar 15, 2024
Taragolis
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Mar 15, 2024
vincbeck
reviewed
Mar 15, 2024
ferruzzi
approved these changes
Mar 15, 2024
Yeah... full test works fine. Except |
o-nikolas
reviewed
Mar 15, 2024
Taragolis
force-pushed
the
aws-base-on-partial
branch
from
March 15, 2024 21:01
994395c
to
0fab3a5
Compare
Fingers crossed, seems like this test should work (without side effects) |
Taragolis
changed the title
Fix
Fix Mar 16, 2024
region
argument in partial for bases on AwsBaseOperator
/ AwsBaseSensor
region
argument in MappedOperator
based on AwsBaseOperator
/ AwsBaseSensor
dirrao
approved these changes
Mar 17, 2024
This reverts commit 32d0964.
Taragolis
force-pushed
the
aws-base-on-partial
branch
from
March 18, 2024 12:06
16e7896
to
1e3489f
Compare
This was referenced Mar 20, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…/ `AwsBaseSensor` (apache#38178) * Fix `region` argument in partial for bases on `AwsBaseOperator` / `AwsBaseSensor` * Add EcsRunTaskOperator.partial test * Revert "Add EcsRunTaskOperator.partial test" This reverts commit 32d0964. * Second attempt with patial EcsRunTaskOperator tests * Add missing session in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
full tests needed
We need to run full set of tests for this PR to merge
provider:amazon-aws
AWS/Amazon - related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported in Slack
Hi everyone! :nyanparrot:
I just upgraded the airflow packages versions:
And now I have a broken DAG:
The use of region is this one:
Does someone know why it is broken?
Thanks a lot 🥹 (edited)
This happen because partial check signature, and if argument not exists in any MRO references it will failed.
We grab
region
directly from kwargs and remove it, for avoid provide it into the BaseOperator.Fix pretty simple, add
region
intoAwsBaseOperator
/AwsBaseSensor
signatures, it should fix all operators which migrated to this helper operators and use deprecatedregion
attribute over Dynamic Task Mapping^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.