Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matomo as an option for analytics_tool. #38221

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

set5think
Copy link
Contributor

@set5think set5think commented Mar 17, 2024

Matomo is a Google Analytics alternative for use-cases that require all tracking data be kept internally, and is set up the same way as the existing supported analytics tools.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Mar 17, 2024
Copy link

boring-cyborg bot commented Mar 17, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR. Can you add the screenshots for the change?

@set5think
Copy link
Contributor Author

Thanks for your first PR. Can you add the screenshots for the change?

thank you @dirrao for the welcome! RE: screenshots, what exactly are you wanting to see? A screenshot of my debug console showing the matomo tracking code injected?

@dirrao
Copy link
Collaborator

dirrao commented Mar 18, 2024

Thanks for your first PR. Can you add the screenshots for the change?

thank you @dirrao for the welcome! RE: screenshots, what exactly are you wanting to see? A screenshot of my debug console showing the matomo tracking code injected?

I am referring to the UI related changes.

@set5think
Copy link
Contributor Author

Hmm, sorry for the confusion here, but there is no UI change I'm aware of with this. The html page is likely what triggered the "area:UI" tag to be added automatically. But it's just a script tag, nothing more. And this mechanism is already tested through the analytics_tool tests. Can you point out what change you're talking about that needs a screenshot? Thanks!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good indeed.

Matomo is a Google Analytics alternative for use-cases that require all
tracking data be kept interally.
@potiuk
Copy link
Member

potiuk commented Mar 19, 2024

Some static checks and docs need fixing though

@set5think
Copy link
Contributor Author

Some static checks and docs need fixing though

yup just saw the failures, on it!

@set5think
Copy link
Contributor Author

@potiuk - I think everything's resolved!

@set5think
Copy link
Contributor Author

ah geez, missed allow-listing "matomo" and "Matomo" for spelling! fixed!

@Taragolis Taragolis added this to the Airflow 2.9.0 milestone Mar 19, 2024
@potiuk potiuk merged commit d3ef673 into apache:main Mar 19, 2024
47 checks passed
Copy link

boring-cyborg bot commented Mar 19, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Mar 20, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Add Matomo as an option for analytics_tool.

Matomo is a Google Analytics alternative for use-cases that require all
tracking data be kept interally.

* add matomo to spelling_wordlist.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants