Only show latest dataset event timestamp after last run #38340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
uranusjr
reviewed
Mar 22, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
bbovenzi
force-pushed
the
fix-next-run-dataset-dates
branch
from
0e82227
to
f73222b
Compare
jedcunningham
approved these changes
Mar 25, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Only show latest dataset event timestamp after last run * Move date filter to join statement in query * Update airflow/www/views.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next run dataset modal, "Last Update" can be confusing since the dataset update events could be irrelevant to the next dag run. Therefore, we should only show the last update event that has happened since the previous dag run.
Before: (Looks like 2 of 2 datasets are updated and its hard to see what we're waiting on)
After: (1 of 2 datasets is a lot more straightforward to see)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.