Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datasets graph UX #38476

Merged
merged 3 commits into from Mar 26, 2024
Merged

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 25, 2024

We had a bunch of complicated logic trying to separate out unconnected dataset "graphs" from each other in the UI. It was buggy and could cause the UI to crash if there were too many datasets. So I decided to refactor a few things wih the tools I have available:

  • Always render the full datasets dependencies graph
  • Merge the Dataset and DAG search bars into one, with a single selection vs multiselect
  • Can click to select a DAG
  • Hover on a DAG shows popover to link to it's page
  • Add loading indicator to the graph
  • Zoom the graph to the node upon selection
  • Highlight edges connected to a DAG
  • Don't have the list/details left panel changing width when changing dataset selection
Screenshot 2024-03-25 at 6 56 02 PM

Mar-25-2024 19-03-17


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 25, 2024
@phanikumv phanikumv merged commit 2218311 into apache:main Mar 26, 2024
44 checks passed
@phanikumv phanikumv deleted the improve-datasets-graph branch March 26, 2024 08:55
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 27, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants